Conversation
Also changed watch implementation to use a separate connection, to avoid having mutex be locked indefinately while a watch is in progress. Seems to also fix weird behavior where watch callback would be called with info object that had garbled action element. However, after running `yarn test` 60 times, only 40 runs were successful. 14 runs ended with: node(47623,0x17012f000) malloc: *** error for object 0x1: pointer being freed was not allocated node(47623,0x17012f000) malloc: *** set a breakpoint in malloc_error_break to debug Stopping samba EXITCODE=129 4 runs ended with: node(48547,0x174603000) malloc: Heap corruption detected, free list is damaged at 0x60000002b7e0 *** Incorrect guard value: 1 node(48547,0x174603000) malloc: *** set a breakpoint in malloc_error_break to debug Stopping samba EXITCODE=129 2 runs had no error messages and no 'should handle watch' - simply ended with: Stopping samba EXITCODE=129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed watch implementation to use a separate connection, to avoid having mutex be locked indefinately while a watch is in progress.
Seems to also fix weird behavior where watch callback would be called with info object that had garbled action element.
However, after running
yarn test60 times, only 40 runs were successful.14 runs ended with:
node(47623,0x17012f000) malloc: *** error for object 0x1: pointer being freed was not allocated node(47623,0x17012f000) malloc: *** set a breakpoint in malloc_error_break to debug Stopping samba EXITCODE=129
4 runs ended with:
node(48547,0x174603000) malloc: Heap corruption detected, free list is damaged at 0x60000002b7e0 *** Incorrect guard value: 1
node(48547,0x174603000) malloc: *** set a breakpoint in malloc_error_break to debug Stopping samba EXITCODE=129
2 runs had no error messages and no 'should handle watch' - simply ended with: Stopping samba EXITCODE=129